Bug 1707896 - Transform generated folder into QML Module when building for Qt #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Dexterp37
approved these changes
May 28, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
(I'll never get used to the dot before import)
Contributor
Author
|
I'll make sure this works on the VPN before merging, making a new release etc. I'll come back here with results, hopefully it will work normally, but my lack of QML knowledge makes me not 100% sure of that. |
This option is unnecessary after the switch to make Glean.js into a QML module
The path to the module is enough identifier it seems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one