Bug 1707896 - Make the Qt package a QML module #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
May 28, 2021
Dexterp37
requested changes
May 28, 2021
Dexterp37
approved these changes
Jun 3, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
Neat. Would you kindly file a bug about adding docs about "adding Glean.js to a QML project"?
Dexterp37
reviewed
Jun 3, 2021
Contributor
Author
|
brizental
force-pushed
the
1707896-nice-qt
branch
from
83d94df to
685eac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft as this depends on mozilla/glean_parser#342
I have tested manually of course, but we will be sure once CI turns out green after updating glean_parser 👀
Just remembered that I still need to: