Skip to content

No bug - Change Qt compilation config to make final lib smaller and target correct specification #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2021
Merged

No bug - Change Qt compilation config to make final lib smaller and target correct specification #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a53ed4
Target ES6 for Qt compilation
brizental Sep 17, 2021
a974801
Use TerserPlugin for minifying Qt library
brizental Sep 23, 2021
81160ac
Use importHelpers compiler flag to make generated Qt lib smaller
brizental Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 75 additions & 82 deletions glean/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions glean/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
"selenium-webdriver": "^4.0.0-alpha.8",
"sinon": "^11.0.0",
"sqlite3": "^5.0.2",
"terser-webpack-plugin": "^5.2.4",
"ts-loader": "^9.0.1",
"ts-node": "^10.0.0",
"typedoc": "^0.22.3",
Expand All @@ -145,6 +146,7 @@
"dependencies": {
"fflate": "^0.7.1",
"jose": "^3.14.0",
"tslib": "^1.14.1",
"uuid": "^8.3.2"
},
"engines": {
Expand Down
3 changes: 2 additions & 1 deletion glean/tsconfig/qt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"extends": "./base.json",
"compilerOptions": {
"target": "ES5"
"target": "ES2016",
"importHelpers": true
},
"include": ["../src/index/qt.ts" ]
}
3 changes: 3 additions & 0 deletions glean/webpack.config.qt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import path, { dirname } from "path";
import { fileURLToPath } from "url";

import TerserPlugin from "terser-webpack-plugin";

const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
Expand Down Expand Up @@ -99,6 +100,8 @@ const productionConfig = {
usedExports: true,
providedExports: true,
sideEffects: true,
minimize: true,
minimizer: [ new TerserPlugin() ],
},
};

Expand Down