No bug - Change Qt compilation config to make final lib smaller and target correct specification #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is advantageous for startes because that is ECMAScript version targeted by the QML Javascript interpreter anyways, but also because it will not compile let/const down to vars which was causing weird behaviour overall. I had to turn off minification on the production library though, because that was hitting a bug in the QML Javascript interpreter: specifically https://bugreports.qt.io/browse/QTBUG-96631
This plugin does not create final code that hits the Qt JS Interprter bug the default minifyier did.
importHelpers adds all polyfills necessary for the ES6 target available on the top of the generated file, instead of defining the necessary polyfills on top of each module and having a lot of code repetition. This makes it easier to debug teh generated file but also makes the final lib considerably smaller. Since Glean.js does not _need_ all the polyfills this also adds a bit of dead code to the top of the compiled lib, that is still better than the redundant mess we had before.
Collaborator
Build size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This group of changes was yanked from #744 .
I took them out of there to make that PR a bit smaller, but also because this group is not immediatelly related to the fix over there. I just happened to find these issues while working on that investigation.