Bug 1728810 - Implement an uploader for the Node.js platform #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chutten
approved these changes
Sep 15, 2021
| // since it is validated upon Glean initialzation | ||
| // TODO: Bug 1730496 | ||
| const parsedURL = new URL(url); | ||
| const mod = parsedURL.protocol === "http:" ? http : https; |
Contributor
There was a problem hiding this comment.
I guess there's an interesting discussion to be had about allowing un-TLS'd connections in Glean to non-local hosts, but this isn't the time or place.
Contributor
Author
There was a problem hiding this comment.
There will be some validation soon https://bugzilla.mozilla.org/show_bug.cgi?id=1730496#c1
brizental
force-pushed
the
1728810-node-uploader
branch
from
0b681a9 to
e5778dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works: https://debug-ping-preview.firebaseapp.com/pings/node-js
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need oneDocumentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work