Skip to content

Commit e5778dc

Browse files
committed
Attend to review comments
1 parent 60e0e72 commit e5778dc

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

glean/src/platform/node/uploader.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ class NodeUploader extends Uploader {
4141

4242
request.on("timeout", () => {
4343
log(LOG_TAG, "Timeout while attempting to upload ping.", LoggingLevel.Error);
44+
request.destroy();
4445
resolve(new UploadResult(UploadResultStatus.RecoverableFailure));
4546
});
4647

glean/src/platform/qt/uploader.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class QtUploader extends Uploader {
2626
};
2727

2828
xhr.onerror = function(e) {
29-
log(LOG_TAG, ["Network rror while attempting to upload ping.\n", e.type], LoggingLevel.Error);
29+
log(LOG_TAG, ["Network error while attempting to upload ping.\n", e.type], LoggingLevel.Error);
3030
resolve(new UploadResult(UploadResultStatus.RecoverableFailure));
3131
};
3232

0 commit comments

Comments
 (0)