Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Unreleased changes

[Full changelog](https://github.com/mozilla/glean.js/compare/v0.11.0...main)
[Full changelog](https://github.com/mozilla/glean.js/compare/v0.12.0...main)

# v0.12.0 (2021-05-11)

[Full changelog](https://github.com/mozilla/glean.js/compare/v0.11.0...v0.12.0)

* [#279](https://github.com/mozilla/glean.js/pull/279): BUGFIX: Ensure only empty pings triggers logging of "empty ping" messages.
* [#288](https://github.com/mozilla/glean.js/pull/288): Support collecting `PlatformInfo` from `Qt` applications. Only OS name and locale are supported.
Expand Down
6 changes: 5 additions & 1 deletion docs/adding_a_new_metric_type.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class StringMetric extends Metric<string, string> {
}
```

Oce you have your `Metric` subclass, include it in Glean.js'
Once you have your `Metric` subclass, include it in Glean.js'
[`METRIC_MAP`](https://github.com/mozilla/glean.js/blob/main/glean/src/core/metrics/utils.ts#L17).
This map will be used as a template for creating metric instances from the metrics database.

Expand All @@ -112,6 +112,10 @@ Still, metric type classes will always have at least one recording function and
> Make sure that, when you included your `Metric` class on the `METRIC_MAP` the property has the
> same value as the `type` property on the corresponding `MetricType`.

Once you are done implementing the `MetricType` class for your new metric type,
make sure to manually expose it for Qt platforms by adding it to
[the Qt entry point file](https://github.com/mozilla/glean.js/blob/main/glean/src/index/qt.ts).

#### Recording functions

_Functions that call Glean.js' database and store concrete values of a metric type._
Expand Down
4 changes: 2 additions & 2 deletions glean/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion glean/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mozilla/glean",
"version": "0.11.0",
"version": "0.12.0",
"description": "An implementation of the Glean SDK, a modern cross-platform telemetry client, for Javascript environments.",
"type": "module",
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion glean/src/core/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const GLEAN_SCHEMA_VERSION = 1;
//
// PACKAGE_VERSION is defined as a global by webpack,
// we need a default here for testing when the app is not build with webpack.
export const GLEAN_VERSION = "0.11.0";
export const GLEAN_VERSION = "0.12.0";

// The name of a "ping" that will include Glean ping_info metrics,
// such as ping sequence numbers.
Expand Down
2 changes: 2 additions & 0 deletions glean/src/index/qt.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import CounterMetricType from "../core/metrics/types/counter.js";
import DatetimeMetricType from "../core/metrics/types/datetime.js";
import EventMetricType from "../core/metrics/types/event.js";
import LabeledMetricType from "../core/metrics/types/labeled.js";
import QuantityMetricType from "../core/metrics/types/quantity.js";
import StringMetricType from "../core/metrics/types/string.js";
import TimespanMetricType from "../core/metrics/types/timespan.js";
import UUIDMetricType from "../core/metrics/types/uuid.js";
Expand Down Expand Up @@ -132,6 +133,7 @@ export default {
DatetimeMetricType,
EventMetricType,
LabeledMetricType,
QuantityMetricType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing the linters work!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAIT. How did this not trigger a failure on the related PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in the related PR you didn't even add anything to Qt :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c610e1e I also updated the docs, see.

StringMetricType,
TimespanMetricType,
UUIDMetricType
Expand Down