Skip to content

Conversation

@brizental
Copy link
Contributor

No description provided.

@brizental brizental requested a review from Dexterp37 May 11, 2021 15:44
DatetimeMetricType,
EventMetricType,
LabeledMetricType,
QuantityMetricType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing the linters work!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAIT. How did this not trigger a failure on the related PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in the related PR you didn't even add anything to Qt :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c610e1e I also updated the docs, see.

@brizental brizental merged commit ac8b943 into main May 11, 2021
@brizental brizental deleted the release-v0.12.0 branch May 11, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants