Skip to content

Bug 1701203 - Declare a minimum node version in the package.json #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Bug 1701203 - Declare a minimum node version in the package.json #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc16543
Fixed the bug that required a minimum node version by adding the engi…
AmrDhaliwal Apr 27, 2021
9702511
Removed extra comma that was causing erros on line 103 of package.jso…
AmrDhaliwal Apr 28, 2021
f4200e2
Fixed npm version from >7.0.0 to >=7.0.0 and added the changes to the…
AmrDhaliwal Apr 28, 2021
441d4fe
Made recommended changes to the CHANGELOG.md and updated the lock fil…
AmrDhaliwal Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

[Full changelog](https://github.com/mozilla/glean.js/compare/v0.10.2...main)

* [#260](https://github.com/mozilla/glean.js/pull/260): Set minimum node (>= 12.0.0) and npm (>= 7.0.0) versions.
* [#202](https://github.com/mozilla/glean.js/pull/202): Add a testing API for the ping type.

# v0.10.2 (2021-04-26)
Expand Down
4 changes: 4 additions & 0 deletions glean/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions glean/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,9 @@
"dependencies": {
"jose": "^3.7.0",
"uuid": "^8.3.2"
},
"engines": {
"node": ">=12.20.0",
Copy link
Contributor

@Dexterp37 Dexterp37 Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you kindly add an entry to our CHANGELOG.md file?

Copy link
Contributor Author

@AmrDhaliwal AmrDhaliwal Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Dexterp37,

I have added the bug as an entry into the CHANGELOG.md file.

"npm": ">=7.0.0"
}
}