Bug 1701203 - Declare a minimum node version in the package.json #260
Conversation
…ne field to package.json.
|
Hey @AmrDhaliwal , thank you for your PR and welcome! This PR is currently failing our CI tests. Would you kindly check why that's happening? You can also run some tests locally with |
AmrDhaliwal
left a comment
AmrDhaliwal
left a comment
There was a problem hiding this comment.
Removed an extra comma from line 103 in package.json in glean that was causing errors.
|
Hi @Dexterp37, It seems there was an extra comma that was causing the problems. |
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
Thanks for making the tests pass! I have one additional small request.
glean/package.json
Outdated
| }, | ||
| "engines": { | ||
| "node": ">=12.20.0", | ||
| "npm": ">7.0.0" |
There was a problem hiding this comment.
I think what we really want is >= here
There was a problem hiding this comment.
I have gone ahead and made that change.
| "uuid": "^8.3.2" | ||
| }, | ||
| "engines": { | ||
| "node": ">=12.20.0", |
There was a problem hiding this comment.
Would you kindly add an entry to our CHANGELOG.md file?
There was a problem hiding this comment.
Hi @Dexterp37,
I have added the bug as an entry into the CHANGELOG.md file.
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
We're almost there! Thanks again for this!
CHANGELOG.md
Outdated
|
|
||
| [Full changelog](https://github.com/mozilla/glean.js/compare/v0.10.2...main) | ||
|
|
||
| * [#260](https://github.com/mozilla/glean.js/pull/260): Set minimum node version to "node": ">=12.0.0". |
There was a problem hiding this comment.
| * [#260](https://github.com/mozilla/glean.js/pull/260): Set minimum node version to "node": ">=12.0.0". | |
| * [#260](https://github.com/mozilla/glean.js/pull/260): Set minimum node (>= 12.0.0) and npm (>= 7.0.0) versions. |
glean/package-lock.json
Outdated
| }, | ||
| "engines": { | ||
| "node": ">=12.20.0", | ||
| "npm": ">7.0.0" |
There was a problem hiding this comment.
Please run npm i --package-lock-only to update the lock file
|
Hi @Dexterp37, I updated the CHANGELOG.md and updated the lock file. |
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
Thank you! And don't worry about the delays, there's no rush :)
2 participants
Fixed the bug that required a minimum node version by adding the engine field to package.json.