Bugs 1855792, 1855795 - window.Glean updates

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 [Full changelog](https://github.com/mozilla/glean.js/compare/v2.0.3...main)
 
+* [#1772](https://github.com/mozilla/glean.js/pull/1772): Fix bug where `window.Glean` functions were getting set on non-browser properties.
+
 # v2.0.3 (2023-09-27)
 
 [Full changelog](https://github.com/mozilla/glean.js/compare/v2.0.2...v2.0.3)

automation/compat/tests/utils.js

@@ -74,6 +74,30 @@ export async function runWebTest(driver) {
     await driver.get(`http://localhost:${PORT}/`);
     // Give it time to send the ping request.
     const successTextContainer = await driver.findElement(By.id("msg"));
+
+    const areGleanWindowVarsSet = await driver.executeScript(() => {
+      // Verify that all Glean `window` vars are properly set.
+      if (
+        window &&
+        window.Glean &&
+        window.Glean.setDebugViewTag &&
+        window.Glean.setLogPings &&
+        window.Glean.setSourceTags
+      ) {
+        return true;
+      }
+
+      // One of our expected values wasn't set, so the test should fail.
+      return false;
+    }).catch(() => {
+      // In case `window` isn't available or something unexpected happens.
+      return false;
+    });
+
+    if (!areGleanWindowVarsSet) {
+      throw new Error("`window.Glean` variables are not set.");
+    }
+
     await driver.wait(
       until.elementTextIs(
         successTextContainer,

glean/src/core/glean/sync.ts

@@ -445,10 +445,13 @@ declare global {
   }
 }
 
-window.Glean = {
-  setLogPings: Glean.setLogPings,
-  setDebugViewTag: Glean.setDebugViewTag,
-  setSourceTags: Glean.setSourceTags
-};
+// Only set `Glean` values whenever running inside of a browser.
+if (typeof window !== "undefined") {
+  window.Glean = {
+    setLogPings: Glean.setLogPings,
+    setDebugViewTag: Glean.setDebugViewTag,
+    setSourceTags: Glean.setSourceTags
+  };
+}
 
 export default Glean;