Bugs 1855792, 1855795 - window.Glean updates

[rosahbruno]

I tested this by pushing up a branch with the dist folder checked in and running this version directly inside of the mdn project. The window is not defined error goes away when wrapped in the typeof window !== undefined check.

Pull Request checklist

• Quality: Make sure this PR builds and runs cleanly.
  • Inside the glean/ folder, run:
    • npm run test Runs all tests
    • npm run lint Runs all linters
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
• Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work
  • Documentation should be added to The Glean Book when making changes to Glean's user facing API
    • When changes to the Glean Book are necessary, link to the corresponding PR on the mozilla/glean repository
  • Documentation should be added to the Glean.js developer documentation when making internal code changes

[caugner]

@rosahbruno Might this need to be typeof window !== "undefined"?

[rosahbruno]

These are actually our browserstack tests. So for this scenario, we want our tests to fail if for some reason we can't find the window object.

The place where we believe this is coming from is fixed in this PR. For whatever reason, our helper function isUndefined isn't working right and is actually leading to the error being thrown. As a fix, we just check directly against window instead.

I tested this by pulling down MDN and running yarn dev with v2.0.4 and reproducing the error. When I retested and did the same thing with the code I pushed to that new branch, I was able to successfully run yarn dev and run the app locally.

Hopefully this should resolve the errors you are seeing whenever we cut a new release!

[caugner]

Awesome, thank you! 🙌

[caugner]

PS: My gut feeling says that passing an undefined variable to isUndefined() just throws an error before you get into the function, because it uses an undefined variable, whereas an explicit typeof varname !== "undefined" never throws.