Skip to content

Conversation

@brizental
Copy link
Contributor

EXTRA: Retry ping request on network error with keepalive: false. This makes the Chrome compat a lot better. See 94ce121.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work
    • Add browser compat docs somewhere

@auto-assign auto-assign bot requested a review from mdboom January 27, 2022 10:57
@brizental brizental marked this pull request as draft January 27, 2022 10:57
@brizental brizental removed the request for review from mdboom January 27, 2022 10:57
@brizental brizental force-pushed the 1741586-browser-compat branch from cef03c5 to d8c457c Compare January 27, 2022 11:14
@mozilla mozilla deleted a comment from moz-glean Jan 27, 2022
@brizental brizental force-pushed the 1741586-browser-compat branch from d8c457c to 94025cb Compare January 27, 2022 11:19
@mozilla mozilla deleted a comment from moz-glean Jan 28, 2022
@brizental brizental force-pushed the 1741586-browser-compat branch 2 times, most recently from b6eacd4 to fcf305b Compare January 28, 2022 09:53
@mozilla mozilla deleted a comment from moz-glean Jan 28, 2022
@brizental brizental force-pushed the 1741586-browser-compat branch from 74a3739 to bc47529 Compare January 28, 2022 10:16
@brizental brizental closed this Jan 28, 2022
@brizental brizental deleted the 1741586-browser-compat branch January 28, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant