Use Node and Python environment for smoke test CI

Author: brizental

.circleci/config.yml

@@ -182,7 +182,7 @@ jobs:
 
   browser-compat-smoke-tests:
     docker:
-      - image: cimg/node:16.1.0
+      - image: cimg/python:3.9.4-node
     steps:
       - checkout
       - run:
@@ -299,10 +299,10 @@ workflows:
                 - main
                 - release
                 - /^release-.*/
-      - check-size:
-          context: data-eng-gleanjs-gh
-          requires:
-            - hold
+      # - check-size:
+      #     context: data-eng-gleanjs-gh
+      #     requires:
+      #       - hold
       - browser-compat-smoke-tests:
           context: data-eng-gleanjs-gh
           requires:

benchmarks/compat/tests/browserstack.test.js

@@ -63,11 +63,14 @@ for (const browser of BROWSERS) {
 
         await runWebTest(driver);
 
-        // Marking the test as passed for Browserstack.
+        // Marking the test as passed for Browserstack
         await driver.executeScript(
           "browserstack_executor: {\"action\": \"setSessionStatus\", \"arguments\": {\"status\":\"passed\",\"reason\": \"Ping successfully sent!\"}}"
         );
       } catch(_) {
+        // Make sure the process exits with an error code
+        process.exitCode = 1;
+        // Marking the test as failed for Browserstack
         await driver.executeScript(
           "browserstack_executor: {\"action\": \"setSessionStatus\", \"arguments\": {\"status\":\"failed\",\"reason\": \"Ping not sent :(\"}}"
         );

benchmarks/compat/tests/utils.js

@@ -45,7 +45,7 @@ export class App {
 /**
  * Executes a smoke test for @mozilla/glean/web.
  *
- * This will execute the sample app in port 3000.
+ * This assumes the app is being executed in port ${PORT}.
  *
  * @param {*} driver A selenium webdriver.
  */
@@ -54,14 +54,14 @@ export async function runWebTest(driver) {
     // Loading the sample webpage will record a metric and submit a ping.
     // If the ping is submitted succesfully an element in the DOM with the id `msg`
     // will receive the text "Ping submitted succesfully."
-    await driver.get(`http://localasdfhost:${PORT}/`);
+    await driver.get(`http://localhost:${PORT}/`);
     // Give it time to send the ping request.
     const successTextContainer = await driver.findElement(By.id("msg"));
     await driver.wait(
       until.elementTextIs(
         successTextContainer,
         "Ping submitted succesfully."
-      ), 60* 5000);
+      ), 5000);
 
     console.log("Test passed.");
   } catch(e) {