Bug 1679379 - Implement the boolean metric type #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
requested changes
Dec 15, 2020
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
I took a first high level pass :) Will take a closer look after this first round.
added 6 commits
December 15, 2020 12:57
They are unnecessary since the check-size job was disabled.
Since this is the first metric type to be implemented, I had to change a bit the database module to record and return a special MetricPayload type instead of simply a string.
brizental
force-pushed
the
1679379-boolean
branch
from
1e607c8 to
4b73cbc
Compare
Dexterp37
requested changes
Dec 15, 2020
Dexterp37
requested changes
Dec 15, 2020
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
See my other comments. My major concern is about the requirement to pass in the Glean object to the specific metrics API.
Contributor
|
@brizental can you also file a bug for adding documentation? Did we settle on adding docs to the Glean Book? |
Contributor
Author
Done https://bugzilla.mozilla.org/show_bug.cgi?id=1682785. Yes, on the MVP proposal we settled on the Glean book and I still stand by that decision, even though I am not clear on how we add Glean.js docs there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.