Fix bug on isBoolean function, attend to review comments

Author: brizental

src/metrics/payload.ts

@@ -5,6 +5,14 @@
 import { BooleanMetricPayload, isBooleanMetricPayload } from "metrics/boolean";
 import { isString } from "utils";
 
+/**
+ * Validates that a given value is the correct type of payload for a metric of a given type.
+ *
+ * @param type The type of the metric to validate
+ * @param v The value to verify
+ *
+ * @returns Whether or not `v` is of the correct type.
+ */
 export function isMetricPayload(type: string, v: unknown): v is MetricPayload {
   switch (type) {
   case "boolean":

src/storage/index.ts

@@ -2,7 +2,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import { isString, isUndefined, isObject, isBoolean, isNumber } from "utils";
+import { isString, isUndefined, isObject, isBoolean } from "utils";
 
 /**
  * The storage index in the ordered list of keys to navigate on the store
@@ -45,7 +45,7 @@ export function isStorageValue(v: unknown): v is StorageValue {
   if (isUndefined(v) || isString(v) || isBoolean(v)) {
     return true;
   }
-  
+
   if (isObject(v)) {
     if (Object.keys(v).length === 0) {
       return true;

src/storage/persistent/webext.ts

@@ -4,7 +4,7 @@
 
 import { Store, StorageIndex, StorageValue, StorageObject, isStorageValue } from "storage";
 import { updateNestedObject, getValueFromNestedObject, deleteKeyFromNestedObject } from "storage/utils";
-import { isString, isUndefined } from "utils";
+import { isObject } from "utils";
 
 type WebExtStoreQuery = { [x: string]: { [x: string]: null; } | null; };
 
@@ -75,7 +75,7 @@ class WebExtStore implements Store {
     }
 
     if (isStorageValue(response)) {
-      if (!isUndefined(response) && !isString(response)) {
+      if (isObject(response)) {
         return getValueFromNestedObject(response, [ this.rootKey, ...index ]);
       } else {
         return response;

src/utils.ts

@@ -3,17 +3,17 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 export function isObject(v: unknown): v is Record<string | number | symbol, unknown> {
-  return !!(v && typeof v === "object" && v.constructor === Object);
+  return (typeof v === "object" && v !== null  && v.constructor === Object);
 }
 
 export function isUndefined(v: unknown): v is undefined {
   return typeof v === "undefined";
 }
 
 export function isString(v: unknown): v is string {
-  return !!(v && (typeof v === "string" || (v === "object" && v.constructor === String)));
+  return (typeof v === "string" || (typeof v === "object" && v !== null  && v.constructor === String));
 }
 
 export function isBoolean(v: unknown): v is string {
-  return !!(v && (typeof v === "boolean" || (v === "object" && v.constructor === Boolean)));
+  return (typeof v === "boolean" || (typeof v === "object" && v !== null && v.constructor === Boolean));
 }

tests/storage.spec.ts

@@ -76,6 +76,7 @@ for (const store in stores) {
       let store: Store;
       const expected = {
         bip: {
+          bling: false,
           bop: {
             blip: "something, something!",
             blergh: "don't panic!",
@@ -93,6 +94,7 @@ for (const store in stores) {
       before(async function () {
         !isUndefined(currentStore.before) && await currentStore.before();
         store = currentStore.initializeStore();
+        await store.update(["bip", "bling"], () => false);
         await store.update(["bip", "bop", "blip"], () => "something, something!");
         await store.update(["bip", "bop", "blergh"], () => "don't panic!");
         await store.update(["bip", "bop", "burp"], () => "you are doing great!");
@@ -116,7 +118,7 @@ for (const store in stores) {
         const value = await store.get(["bip", "bop", "inexistent"]);
         assert.strictEqual(value, undefined);
       });
-  
+
       it("Attempting to get an index that contains an object works", async function () {
         const value = await store.get(["bip", "bok"]);
         assert.deepStrictEqual(value, expected["bip"]["bok"]);
@@ -126,6 +128,11 @@ for (const store in stores) {
         const value = await store.get(["bump"]);
         assert.deepStrictEqual(value, expected["bump"]);
       });
+
+      it("Attempting to get an index that contains a boolean works", async function () {
+        const value = await store.get(["bip", "bling"]);
+        assert.strictEqual(value, expected["bip"]["bling"]);
+      });
     });
 
     describe("update", function () {