Skip to content

fix unwrap script re #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2021
Merged

fix unwrap script re #178

merged 3 commits into from
Jul 27, 2021

Conversation

@g-k
Copy link
Contributor

@g-k g-k commented Jul 27, 2021

Rebased #161 with a few updates

Overall changes:

dannyrohde and others added 3 commits July 27, 2021 14:38
@dannyrohde
Fix unwrap script regex
ea5b8ee 
Regex needs to be non-greedy before finding a closing '>' to ensure it will capture the complete script in the capture group
Add test for script unwrapping
@dannyrohde
Update documentation
9d9c3f4 
Update documentation to explain how to load the 'csp' template tag
tests: print template strings when not equal
70f65b8
@g-k g-k force-pushed the fix-unwrap-script-re branch from 78d5b64 to 70f65b8 Compare July 27, 2021 19:03
@g-k g-k marked this pull request as ready for review July 27, 2021 19:04
@g-k g-k merged commit 0d6dbf8 into main Jul 27, 2021
@g-k g-k deleted the fix-unwrap-script-re branch July 27, 2021 19:06
@g-k g-k mentioned this pull request Jul 27, 2021
Closed
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@g-k @OnlineCop @dannyrohde