Fix RegEx to unwrap scripts in utils.py #155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this is my first ever PR, so not sure about the process. Happy to be educated :) |
|
See regexr.com/57ggk for an example. Also, RegExR complains about the unescaped "/" in "</script>". Seems to work without unescaping it, just wanted to let you know. |
|
Also made a small update on the documentation. Not sure how to separate this into another pull request though. |
g-k
reviewed
Aug 12, 2020
There was a problem hiding this comment.
@dannyrohde thanks for this PR! Can you add some test cases to test_utils.py or test_templatetags.py for the issue?
|
Create a feature branch on the fork and this closed the pull request. New PR is #161 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script tag in regular expression needs to be not greedy. Otherwise, it will cut off any scripts that have a ">" in them.
e.g. the line "if (attempts > 100) {" would be cut at the ">" character and the script won't work anymore.