Skip to content

fix: backdate created_at in flaky purge test #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taddes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: backdate created_at in flaky purge test #2635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tools/tokenserver/test_purge_old_records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

from database import Database
from purge_old_records import purge_old_records
from util import get_timestamp


class _RecordingMetrics:
Expand Down Expand Up @@ -391,11 +392,19 @@ def test_failed_service_delete_does_not_abort_batch(purge_db, mock_service_serve
# Two old user records share one batch. Assertions below are independent
# of processing order — the failing row must be bumped and the healthy
# row purged regardless of which is seen first.
# Backdate created_at: update_user only marks rows with
# created_at < now as replaced, so allocating and updating in the
# same millisecond would leave the old row unreplaced.
created_at = get_timestamp() - 1000
healthy_email = "healthy@mozilla.com"
healthy = database.allocate_user(healthy_email, client_state="aa", generation=1)
healthy = database.allocate_user(
healthy_email, client_state="aa", generation=1, timestamp=created_at
)
database.update_user(healthy, client_state="bb", generation=2)
broken_email = "broken@mozilla.com"
broken = database.allocate_user(broken_email, client_state="aa", generation=1)
broken = database.allocate_user(
broken_email, client_state="aa", generation=1, timestamp=created_at
)
database.update_user(broken, client_state="bb", generation=2)

broken_old = next(
Expand Down
Loading