Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_failed_service_delete_does_not_abort_batch flakes with StopIteration. allocate_user and update_user can land in the same millisecond, and update_user only marks rows with created_at < now as replaced, so the old row never gets replaced_at set. Backdating created_at on the allocate_user calls makes the replace always apply.
Failed run (postgres-e2e-tests on #2604):
https://github.com/mozilla-services/syncstorage-rs/actions/runs/37988399669/job/114019738510
(I'd seen it before, though...)
Testing
CI e2e suites. The race is timing dependent so it won't reproduce on demand.
Issue(s)
Closes STOR-751.