Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate license-check from argparse to click #47

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Migrate license-check from argparse to click #47

merged 1 commit into from
Nov 6, 2024

Conversation

relud
Copy link
Member

@relud relud commented Nov 5, 2024

for #39

@relud relud requested a review from a team as a code owner November 5, 2024 21:24
@relud relud force-pushed the relud-click-license-check branch from 0ce1061 to 8d36829 Compare November 5, 2024 21:25
willkg
willkg approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's nice using things like click.Path which takes care of a bunch of things for us.

obs_common/license_check.py
target
for path in targets
for target in (path.rglob("*") if path.is_dir() else [path])
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty hard to read and reason about especially with the singular/plural variations of target.

@relud relud added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 0feb58f Nov 6, 2024
3 checks passed
@relud relud deleted the relud-click-license-check branch November 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkg willkg willkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@relud @willkg