-
Notifications
You must be signed in to change notification settings - Fork 97
Bug 1862955 - add (optional) session_id & session_count to Glean client info #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1862955 - add (optional) session_id & session_count to Glean client info #795
Conversation
82d9ff3 to
b27a064
Compare
|
@akkomar |
akkomar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since I haven't seen the fields that are added here documented in bugs or in the doc, can you re-request the review when mozilla/glean.js#1850 is finalized?
@whd this will add two fields to all Glean tables. Do you want a heads-up before merge?
whd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whd this will add two fields to all Glean tables. Do you want a heads-up before merge?
No unless you want to manually verify the efficacy of this PR in stage without automatically propagating to prod. Scanning history I can't recall being involved in the previous changes to these schemas. I'm mostly interested in PB[ER] changes since those can require an ingestion-sink code update.
akkomar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed this to a branch in this repo to confirm that all tests are passing: https://app.circleci.com/pipelines/github/mozilla-services/mozilla-pipeline-schemas/3369/workflows/67927c70-749e-4dea-b2c0-712240212177
4e22387 to
ed0a2d4
Compare
Checklist for reviewer:
./.github/push-to-trigger-integration <username>:<branchname>For glean changes:
templates/include/glean/CHANGELOG.mdFor modifications to schemas in restricted namespaces (see
CODEOWNERS):