Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove code for skipping L1 messages #164

Merged
merged 5 commits into from
Dec 4, 2024
Merged

feat: Remove code for skipping L1 messages #164

merged 5 commits into from
Dec 4, 2024

Conversation

FletcherMan
Copy link
Collaborator

1. Purpose or design rationale of this PR

We have updated the ZK Proof system, ensuring that no L1 message fails to execute due to circuit rows overflow. An L1 message will only be excluded from a block if its gas cost exceeds the block's gas limit—a scenario that is highly unlikely since we cap the gas usage for L1 messages in the Layer 1 contract. Even if a sequencer encounters such an L1 message, it will pause processing subsequent messages until the gas limit of the block is increased to accommodate the message.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@FletcherMan FletcherMan requested a review from a team as a code owner December 4, 2024 04:08
@FletcherMan FletcherMan requested review from yunxu1 and removed request for a team December 4, 2024 04:08
@FletcherMan FletcherMan merged commit 9cd5bb2 into review Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants