Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blacklist nil pointer #158

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix blacklist nil pointer #158

merged 1 commit into from
Oct 28, 2024

Conversation

FletcherMan
Copy link
Collaborator

1. Purpose or design rationale of this PR

fix blacklist nil pointer

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@FletcherMan FletcherMan requested a review from a team as a code owner October 25, 2024 00:23
@FletcherMan FletcherMan requested review from yunxu1 and removed request for a team October 25, 2024 00:23
@FletcherMan FletcherMan merged commit 1fe0e4d into main Oct 28, 2024
@FletcherMan FletcherMan deleted the fix_tx_blacklist branch October 28, 2024 01:50
FletcherMan added a commit that referenced this pull request Dec 4, 2024
* fix blacklist nil pointer (#158)

Co-authored-by: fletcher.fan <fletcher.fan@bitget.com>

* remove skip (#159)

* increase holesky max tx per block to 1000 (#160)

* update for holesky build rule

---------

Co-authored-by: fletcher.fan <fletcher.fan@bitget.com>
Co-authored-by: marvel.yu <marvelfisher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants