This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Enable searching customers by their IDs and optimize # of database queries #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vxio
commented
Oct 8, 2020
alovak
reviewed
Oct 9, 2020
adamdecaf
approved these changes
Oct 9, 2020
alovak
approved these changes
Oct 12, 2020
fix: bug in updating a customer's phones and addresses
darwinz
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two main changes:
Adds the ability to search by customerIDs:
GET /customers?customerIDs=id_1,id_2Reduces the number of database queries triggered by
GET /customersA call to
GET /customersthat matchesn=25customers would trigger~100 or n*4database queries:searchCustomerswould callgetCustomer()ntimesgetCustomer()would also trigger 3 additional db queries to fetch the customer's addresses, phones, and metadata.Thus,
n * ( getCustomer() + getAddresses() + getPhones() + getMetadata() ) -> 25 * (1+1+1+1) = 100Fixes #220 #216