fix: bug in updating a customer's phones and addresses

[vxio]

Fixes #239 and a similar bug related to updating a customer's addresses

Calling PUT /customers/{id} should delete any customer phones or addresses not in the request body — or upsert the specified phone or address values.

[vxio]

tx.Rollback() was being called multiple times but it only needs to be called once in a defer since a rollback won't occur if the transaction is successfully commited.

Source: https://stackoverflow.com/questions/46421602/why-defer-a-rollback

[adamdecaf]

TIL. I didn't know Rollback checked if the transaction was successful or not.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@ea53223). Click here to learn what that means.
The diff coverage is 67.56%.

@@            Coverage Diff            @@
##             master     #240   +/-   ##
=========================================
  Coverage          ?   58.57%           
=========================================
  Files             ?       52           
  Lines             ?     2911           
  Branches          ?        0           
=========================================
  Hits              ?     1705           
  Misses            ?      893           
  Partials          ?      313           

[alovak]

Interesting, that we update/delete phone by number which may be formatted in different way. Adding constraint to db based on customerID and phone number will not work for 100% of cases. As we have separate customers_phones table maybe we just should add endpoints to manage customer's phones by ID?

[adamdecaf]

I think phone number normalization / validation would come in v0.6.x as part of the larger data validation issue.