Skip to content

Promote Generic.Arrays.DisallowLongArraySyntax to error #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Promote Generic.Arrays.DisallowLongArraySyntax to error #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ This project adheres to [Semantic Versioning](https://semver.org/).
The format of this change log follows the advice given at [Keep a CHANGELOG](https://keepachangelog.com).

## [Unreleased]
### Changed
- The `Generic.Arrays.DisallowLongArraySyntax` rule has been changed to an error as planned in #58.
Copy link
Preview

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There is a double space before #58. Consider removing the extra space to read 'as planned in #58.'

Suggested change
- The `Generic.Arrays.DisallowLongArraySyntax` rule has been changed to an error as planned in #58.
- The `Generic.Arrays.DisallowLongArraySyntax` rule has been changed to an error as planned in #58.

Copilot uses AI. Check for mistakes.


## [v3.4.11] - 2025-06-26
### Fixed
- The `moodle.Commenting.InlineComment` sniff will now accept a full-stop inside a closing parentheses as valid English.
Expand Down
5 changes: 0 additions & 5 deletions moodle-extra/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
<!-- Extend the standard Moodle coding style -->
<rule ref="moodle"/>

<!-- This is an error in moodle-extra. TODO: Remove as part of #58 -->
<rule ref="Generic.Arrays.DisallowLongArraySyntax">
<type>error</type>
</rule>

<!-- Include the PSR-12 ruleset with relevant Moodle exclusions -->
<rule ref="PSR12">

Expand Down
2 changes: 1 addition & 1 deletion moodle/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<arg name="encoding" value="utf-8" />

<rule ref="Generic.Arrays.DisallowLongArraySyntax">
<type>warning</type>
<type>error</type>
</rule>

<!--
Expand Down