Promote Generic.Arrays.DisallowLongArraySyntax to error
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=========================================
Coverage 98.21% 98.21%
Complexity 954 954
=========================================
Files 40 40
Lines 2962 2962
=========================================
Hits 2909 2909
Misses 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Promote the Generic.Arrays.DisallowLongArraySyntax sniff to an error, remove its redundant definition in the extra ruleset, and document the change.
- Changed the
DisallowLongArraySyntaxrule level from warning to error in the main ruleset - Removed the duplicate rule (and its TODO) from
moodle-extra/ruleset.xml - Added an Unreleased changelog entry for this promotion
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| moodle/ruleset.xml | Updated DisallowLongArraySyntax rule type to error |
| moodle-extra/ruleset.xml | Removed redundant DisallowLongArraySyntax rule block |
| CHANGELOG.md | Documented the rule promotion under Unreleased changes |
| @@ -6,6 +6,9 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
| The format of this change log follows the advice given at [Keep a CHANGELOG](https://keepachangelog.com). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Changed | |||
| - The `Generic.Arrays.DisallowLongArraySyntax` rule has been changed to an error as planned in #58. | |||
There was a problem hiding this comment.
[nitpick] There is a double space before #58. Consider removing the extra space to read 'as planned in #58.'
Suggested change
| - The `Generic.Arrays.DisallowLongArraySyntax` rule has been changed to an error as planned in #58. | |
| - The `Generic.Arrays.DisallowLongArraySyntax` rule has been changed to an error as planned in #58. |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58