Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mjson dependencies #146

Merged
merged 28 commits into from
Aug 9, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
f8db135
Bootstrap bluebird from app package
cdebost Jan 8, 2019
677bd00
Remove strategy in favor of recursive retry libs
cdebost Jan 8, 2019
5748a97
Make flat-module-tree spec more accurate
cdebost Jan 10, 2019
f938821
Rename nested-module-tree spec to legacy-bundling
cdebost Jan 24, 2019
33ee5fb
Change node 9 to 10 in CI, 9 is not LTS
cdebost Jan 25, 2019
17f0ea4
Use package-lock.json to resolve dependencies
cdebost Jan 24, 2019
7888981
Run integration with mop#feature/npm3
cdebost Jan 31, 2019
aaff8e9
Update config.packages on location rewrite
cdebost Jan 29, 2019
0b5c1ae
Only load package-lock.json when not mopped
cdebost Jan 31, 2019
3d53d09
Bump version to 18.0.0-rc1
cdebost Feb 7, 2019
ce29acb
Merge branch 'master' into feature/npm3
cdebost Feb 12, 2019
752ee12
Prepare 18.0.0-rc2
cdebost Feb 13, 2019
596a4d1
- processes dependencies in montage serializations as they are in jav…
marchant Feb 12, 2019
4676b68
Addresses typos, remove comments
marchant Feb 12, 2019
83f548c
- processes dependencies in montage serializations as they are in jav…
marchant Feb 12, 2019
b789abb
Addresses typos, remove comments
marchant Feb 12, 2019
6141359
Removes spec for mjson as the capability now fully lives in montage
marchant Mar 28, 2019
21746ec
slight performance optimiztion
marchant Mar 28, 2019
c496f66
- removes mjson processing
marchant Mar 28, 2019
944f149
Fixes a regression
marchant Mar 31, 2019
26b09b8
Fixes a regression to make sure that object intances aren't set isIns…
marchant Mar 31, 2019
e6239e0
Prevents reading a property on undefined argument
marchant Aug 6, 2019
396ca65
Updates version to rc2 and engines dendencies
marchant Aug 8, 2019
d782a49
Merge branch 'master' into better-mjson-dependencies
marchant Aug 9, 2019
113bd01
Fixes 2 lint issues
marchant Aug 9, 2019
0829178
Merge branch 'better-mjson-dependencies' of https://github.com/marcha…
marchant Aug 9, 2019
d989a00
Removes duplicate variable definition
marchant Aug 9, 2019
c71fc9c
Fixes remainig lint issues
marchant Aug 9, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make flat-module-tree spec more accurate
  • Loading branch information
cdebost committed Feb 7, 2019
commit 5748a975b44eb45a183e3c3f9fe139d1ca414249
3 changes: 0 additions & 3 deletions test/spec/flat-module-tree/node_modules/child/index.js

This file was deleted.

3 changes: 0 additions & 3 deletions test/spec/flat-module-tree/node_modules/child/package.json

This file was deleted.

2 changes: 2 additions & 0 deletions test/spec/flat-module-tree/node_modules/http-server/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions test/spec/flat-module-tree/node_modules/nested/index.js

This file was deleted.

7 changes: 0 additions & 7 deletions test/spec/flat-module-tree/node_modules/nested/package.json

This file was deleted.

Empty file.
4 changes: 4 additions & 0 deletions test/spec/flat-module-tree/node_modules/path/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/spec/flat-module-tree/node_modules/url/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions test/spec/flat-module-tree/node_modules/url/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions test/spec/flat-module-tree/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"dependencies": {
"nested":"*"
}
}
"_args": [],
"dependencies": {
"http-server": "1",
"url": "2"
}
}
44 changes: 42 additions & 2 deletions test/spec/flat-module-tree/program.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,44 @@
/*
* Up to npm 3, npm always installed packages in the package's node_modules
* directory. Starting in npm 3, npm now tries to avoid duplication by floating
* dependencies-of-dependencies as far up the directory structure as possible
* without causing version conflicts.
*
* This means when a module requires a node_module, that dependency may have
* been installed to ./node_modules, ../node_modules, ../../node_modules, etc.
* There is no way to determine where a dependency has been installed (until
* npm 5's package-lock.json), as npm 3+ is non-deterministic and the location
* a dependency is installed to can change depending on install order.
*
* Imagine a simple web application project that runs an http server. The
* packages are: http-server, url, and path. The dependencies between packages
* are:
*
* flat-module-tree -> [http-server@1, url@2] flat-module-tree
* http-server@1 -> [path@1, url@1] / \
* url@1 -> [path@1] http-server@1 url@2
* url@2 -> [path@2] / \ |
* path@1 -> [] path@1 <- url@1 path@2
* path@2 -> []
*
* This test's directory structure is a possible result of running npm install:
*
* flat-module-tree
* |
* node_modules
* / | \
* http-server@1 path@2 url@2
* |
* node_modules
* / \
* url@1 path@1
*
* To understand how npm 3+ works and why it is non-deterministic, see
* https://npm.github.io/how-npm-works-docs/npm3/how-npm3-works.html
*/

var test = require('test');
var nested = require('nested');
test.assert(nested.foo() === 1, 'child module identifier');

require("http-server");
require("url");
test.print('DONE', 'info');