Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mjson dependencies #146

Merged
merged 28 commits into from
Aug 9, 2019

Conversation

marchant
Copy link
Member

This is meant to be merged on top of feature/npm3. The primary goal is to solve a bug with deserializing nested montage serializations, which happens with the use of serializations in montage/data and the use of "object":"moduleId".

  • the way dependencies/moduleId are now analyzed and pre-loaded for .mjson, the way they are for JS files, opens the door for adding a factory where the deserialization would happen, as long as we evolve montage deserialization to have an all-sync API. This should minimize the amount of promises created during deserialization, simplify the code and speed it up. Once this is available in montage, the rest of the work can happen here.

@marchant marchant requested a review from cdebost February 12, 2019 07:00
Copy link
Collaborator

@cdebost cdebost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be linted.

require.js Outdated Show resolved Hide resolved
require.js Show resolved Hide resolved
require.js Outdated Show resolved Hide resolved
require.js Show resolved Hide resolved
require.js Outdated Show resolved Hide resolved
require.js Outdated Show resolved Hide resolved
require.js Outdated Show resolved Hide resolved
require.js Outdated Show resolved Hide resolved
require.js Outdated Show resolved Hide resolved
require.js Outdated Show resolved Hide resolved
cdebost and others added 6 commits February 12, 2019 15:58
…ascript

- fixes bug where nested serializations don't have the right require
- doesn't use delegate beyond current use
- should evolve to use a factory function for .mjson to postpone deserialization until execution.
- such factory requires a new synchronous deserialization now possible
…ascript

- fixes bug where nested serializations don't have the right require
- doesn't use delegate beyond current use
- should evolve to use a factory function for .mjson to postpone deserialization until execution.
- such factory requires a new synchronous deserialization now possible
@marchant marchant force-pushed the better-mjson-dependencies branch from bf6e291 to b789abb Compare February 13, 2019 06:30
- introduces a delegate compiler to handle any new thing, first is mjson
- New delegate compiler in montage.js now make use of this
- a few performance improvements
@marchant
Copy link
Member Author

marchant commented Aug 9, 2019

Still Mop issues to fix, will do when the body of work and dependencies is squared out on master

@marchant marchant merged commit b40abca into montagejs:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants