-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better mjson dependencies #146
Merged
marchant
merged 28 commits into
montagejs:master
from
marchant:better-mjson-dependencies
Aug 9, 2019
Merged
Better mjson dependencies #146
marchant
merged 28 commits into
montagejs:master
from
marchant:better-mjson-dependencies
Aug 9, 2019
+109
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If bluebird can't be loaded from the app package, it will be retried under mr (npm 2 / legacy bundling support).
cdebost
requested changes
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be linted.
…ascript - fixes bug where nested serializations don't have the right require - doesn't use delegate beyond current use - should evolve to use a factory function for .mjson to postpone deserialization until execution. - such factory requires a new synchronous deserialization now possible
…ascript - fixes bug where nested serializations don't have the right require - doesn't use delegate beyond current use - should evolve to use a factory function for .mjson to postpone deserialization until execution. - such factory requires a new synchronous deserialization now possible
bf6e291
to
b789abb
Compare
- introduces a delegate compiler to handle any new thing, first is mjson - New delegate compiler in montage.js now make use of this - a few performance improvements
…tance to false in their metadata.
…nt/mr into better-mjson-dependencies
Still Mop issues to fix, will do when the body of work and dependencies is squared out on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be merged on top of feature/npm3. The primary goal is to solve a bug with deserializing nested montage serializations, which happens with the use of serializations in montage/data and the use of "object":"moduleId".