Skip to content

Remove 10 minute cursorTimeout comment from GridFSFindOptions docs #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanav33
Copy link
Contributor

@sanav33 sanav33 commented Aug 1, 2022

The cursor timeout value is now configurable on a per server basis: https://jira.mongodb.org/browse/SERVER-8188. Additionally, the spec did not mark the skip option in GridFSFindOptions as optional.

@sanav33 sanav33 requested a review from a team as a code owner August 1, 2022 20:53
@sanav33 sanav33 requested review from alcaeus and kmahar and removed request for a team August 1, 2022 20:53
@ShaneHarvey
Copy link
Member

ShaneHarvey commented Aug 1, 2022

Changes LGTM but I believe noCursorTimeout=True doesn't actually do anything at all on 4.4.8+ servers due to the session timeout behavior described in https://jira.mongodb.org/browse/DRIVERS-1602 and https://jira.mongodb.org/browse/SERVER-6036.

You might want to skip implementing the noCursorTimeout option altogether in Rust.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As @ShaneHarvey commented, the session timeout (which comes into effect for operations outside a session due to the drivers starting an implicit session) overrides the noCursorTimeout option, again creating an implicit timeout for cursors.

@kmahar
Copy link
Contributor

kmahar commented Aug 2, 2022

Thanks for the extra context @ShaneHarvey and @alcaeus. I agree we could probably skip this option then @sanav33, we've got very few users on MongoDB versions < 5.0

@sanav33 sanav33 merged commit b63ea83 into mongodb:master Aug 2, 2022
@sanav33 sanav33 deleted the remove-preset-timeout-value-gridfs-find branch August 2, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants