RUST-1401 Additional GridFS API #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
requested review from
a team and
abr-egn
and removed request for
a team
abr-egn
approved these changes
Oct 13, 2022
| pub async fn delete(&self, id: Bson) -> Result<()> { | ||
| let delete_result = self | ||
| .files() | ||
| .delete_one(doc! { "_id": id.clone() }, None) |
There was a problem hiding this comment.
Just to validate - delete doesn't return an error if zero documents match, correct?
There was a problem hiding this comment.
yep, just verified in the shell
kmahar
reviewed
Oct 14, 2022
src/gridfs/options.rs
Outdated
| @@ -82,9 +82,28 @@ pub struct GridFsFindOptions { | |||
| /// The maximum amount of time to allow the query to run. | |||
| pub max_time: Option<Duration>, | |||
|
|
|||
| /// The server normally times out idle cursors after an inactivity period to prevent excess | |||
There was a problem hiding this comment.
back when Sana did the API sketch we actually decided against supporting this option as it has no effect on MongoDB 4.4+ and we have next to no users on MongoDB < 5.0 - see Shane's comment here: mongodb/specifications#1289 (comment)
There was a problem hiding this comment.
Ah I had forgotten about that, I thought we had missed it in the first pass. Removed.
patrickfreed
approved these changes
Oct 15, 2022
kmahar
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the remaining API methods defined in the GridFS spec, including the advanced API.