Skip to content

Using ReadPreference.Secondary causes issues if read_secondary is not supplied with true #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Using ReadPreference.Secondary causes issues if read_secondary is not supplied with true #741

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3157f1a
allow read_secondary on replicaset constructor to be optional in favo…
Oct 22, 2012
611dd4f
allow read_secondary on replicaset constructor to be optional in favo…
m4tty Oct 22, 2012
3ec315d
fix name
m4tty Oct 22, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/mongodb/connection/repl_set.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ var ReplSet = exports.ReplSet = function(servers, options) {
this._readPreference = null;
}

// If readpreference isn't set to primary only, then we'll need to allow reads from secondaries
if (this._readPreference != "primary") {
this._readSecondary = true;
}

// Strategy for picking a secondary
this.secondaryAcceptableLatencyMS = this.options['secondaryAcceptableLatencyMS'] == null ? 15 : this.options['secondaryAcceptableLatencyMS'];
this.strategy = this.options['strategy'];
Expand Down