Using ReadPreference.Secondary causes issues if read_secondary is not supplied with true #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of new ReadPreference object, as we have enough information to know if we want to allow reading of secondary. Also, setting ReadPreference.SecondaryWhatever without read_secondary=true causes allRawConnections() to return less and ultimately cause unauthenticated servers to be in the replicaset
…r of new ReadPreference object, as we have enough information to know if we want to allow reading of secondary. Also, setting ReadPreference.SecondaryWhatever without read_secondary=true causes allRawConnections() to return less and ultimately cause unauthenticated servers to be in the replicaset
|
thanks for the pull request. would you please add tests that exercise the changes? |
|
I need a test that reproduces the issue, can your provide one please |
christkv
added a commit
that referenced
this pull request
Oct 29, 2012
|
actually setting the read_secondary is correct as it triggers a specific slaveOk bit |
|
Not sure what you meant in the last comment, but the change referenced above ( f6ca881 ) takes care of the issue I posted... with .readSecondary not being set and truncating the return from allRawConnections(). Now we have a "default" value for readSecondary when using the readpreference object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed for leaving read_secondary option off of ReplicaSet constructor as we have enough information from the new ReadPreference object to know the secondary allowed setting.
Supplying ReadPreference.SecondaryWhatever without read_secondary=true causes allRawConnections() to return with no secondaries in the connections list (to db.authenticate()) and ultimately cause unauthenticated servers to be in the replicaset connection pool but still used and ultimately downstream auth failures.