wip: using bson for buffer calls #4840
Draft
+268
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadjik1
reviewed
Jan 14, 2026
src/cmap/commands.ts
Outdated
| const AWAIT_CAPABLE = 8; | ||
|
|
||
| const encodeUTF8Into = BSON.BSON.onDemand.ByteUtils.encodeUTF8Into; | ||
| const encodeUTF8Into = BSON.onDemand.ByteUtils.encodeUTF8Into; |
Member
There was a problem hiding this comment.
ByteUtils should be available from the BSON ns (we remove them from onDemand)
Suggested change
| const encodeUTF8Into = BSON.onDemand.ByteUtils.encodeUTF8Into; | |
| const encodeUTF8Into = BSON.ByteUtils.encodeUTF8Into; |
Contributor
Author
There was a problem hiding this comment.
Removed onDemand references.
1. using Uint8Array instead of Buffer in all internal code 2. enabling eslint rule to block Buffer use in src 3. using BSON's ByteUtils in places where we depended on Buffer operations 4. using ByteUtils.isUint8Array instead of Buffer.isBuffer 5. introduced writeInt32LE wrapper that uses the same order of variables, to avoid embarassing mistakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
Steps to run locally:
npm linknpm link ../js-bson(Note: double-check the path)What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript