fix(NODE-7397): Use type predicate for isUint8Array #860
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
baileympearson
approved these changes
Jan 15, 2026
PavelSafronov
changed the title
5 tasks
PavelSafronov
added a commit
to PavelSafronov/node-mongodb-native
that referenced
this pull request
Jan 15, 2026
tadjik1
reviewed
Jan 16, 2026
addaleax
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Use type predicate for isUint8Array so we don't have to cast the value.
What is the motivation for this change?
value is Uint8Arrayis the preferred result of isUint8Array, it communicates whether the value is Uint8Array or not to the TS type system.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: description