test(NODE-5370): add e2e testing for the search index management API #3736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
DRIVERS-2630-search-indexes-testing
branch
from
5c4c0ee to
dd78b8d
Compare
baileympearson
changed the title
|
evergreen retry |
baileympearson
force-pushed
the
DRIVERS-2630-search-indexes-testing
branch
from
8734149 to
8e65be8
Compare
baileympearson
changed the title
baileympearson
force-pushed
the
DRIVERS-2630-search-indexes-testing
branch
2 times, most recently
from
267ec5d to
6053e83
Compare
baileympearson
changed the title
baileympearson
commented
Jul 17, 2023
| @@ -28,7 +29,9 @@ export class DropSearchIndexOperation extends AbstractCallbackOperation<void> { | |||
| } | |||
|
|
|||
| server.command(namespace, command, { session }, err => { | |||
| if (err) { | |||
| const isNamespaceNotFoundError = | |||
There was a problem hiding this comment.
This is clarified in the spec based on discussion in dbx-devs. I think this is okay to pull in because it's non-breaking, even though it's a behavior change for users.
There was a problem hiding this comment.
#3780
conflict from the async/await refactor here.
Should we make this change in v5 as well?
There was a problem hiding this comment.
This was a spec improvement, I think we're okay not backporting it (especially since I don't think we'll backport the e2e tests)
4 tasks
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Jul 18, 2023
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Jul 18, 2023
5 tasks
GromNaN
reviewed
Jul 20, 2023
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Jul 24, 2023
baileympearson
force-pushed
the
DRIVERS-2630-search-indexes-testing
branch
from
008fb47 to
e130803
Compare
durran
added
the
Primary Review
durran
approved these changes
Aug 3, 2023
durran
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR adds e2e testing for the new search index management helpers.
Is there new documentation needed for these changes?
No.
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript