Skip to content

refactor(NODE-5480): search index operations to use async syntax #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

malikj2000
Copy link
Contributor

@malikj2000 malikj2000 commented Jul 20, 2023

Description

search index operations now use async/await syntax

What is changing?

each search index operation inherits from AbstractOperation and calls server.commandAsync

Is there new documentation needed for these changes?

None

What is the motivation for this change?

further converting the driver to use async syntax

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@malikj2000 malikj2000 changed the title updated search index operations to use async/await refactor(NODE-5480): refactor search index operations to use async syntax Jul 20, 2023
@nbbeeken nbbeeken self-requested a review July 20, 2023 21:04
@nbbeeken nbbeeken self-assigned this Jul 20, 2023
@nbbeeken nbbeeken added the Team Review Needs review from team label Jul 20, 2023
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken changed the title refactor(NODE-5480): refactor search index operations to use async syntax refactor(NODE-5480): search index operations to use async syntax Jul 21, 2023
@nbbeeken nbbeeken merged commit c7c5dae into main Jul 21, 2023
@nbbeeken nbbeeken deleted the NODE-5480 branch July 21, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants