GH Actions tests for Rails 7 #5111
Conversation
|
Hi @johnnyshields , thank you for the PR. As I mentioned in the bson-ruby PR, we will need to do a few things in order for ruby 3.1 to be testable in evergreen. If you extract the changes to yaml safe load etc. that don't deal with ruby or rails version into their own PR I think those can be merged right away. |
|
YAML.safe_load changes here: #5112 |
johnnyshields
force-pushed
the
ruby-31-rails-7
branch
from
1bd600f to
90379a4
Compare
| s.add_dependency("activemodel", [">=6.0", "<6.2"]) | ||
| end | ||
| # activemodel 7.0.0 cannot be used due to Class#descendants issue (see: https://github.com/rails/rails/pull/43951) | ||
| s.add_dependency("activemodel", ['>=5.1', '<7.1', '!= 7.0.0']) |
There was a problem hiding this comment.
I think we need a comment here saying that on Ruby 3 activemodel >= 6.0 is required to retain that note but the previous conditional that is being removed in this PR probably isn't valid in the gemspec, @comandeo do you agree?
There was a problem hiding this comment.
Rails 5.x does not support Ruby 3. This is not something specific to Mongoid, so I don't see why the Mongoid gem would need to add any comment or conditional logic here. See: rails/rails#40938
|
it seems it can be merged now cause 7.0.1 is out https://twitter.com/rails/status/1479214221506322433 |
|
Specs are green! Let's merge @p-mongo |
|
I folded this PR into #5122. |
This PR adds GH Actions tests supports for Rails 7.
Currently, this PR is blocked for Ruby 3.1 + Rails 7.0.0 support due to a last-minute change (hence I've disallowed 7.0.0 as a version.) This will be fixed in Rails 7.0.1. See rails/rails#43951.