Skip to content

TOOLS-4263 Update the JS -> Go conversion skill based on reviewer comments - #1148

Merged
autarch merged 1 commit into
masterfrom
08-20-tools-4263_update_the_js_-_go_conversion_skill_based_on_reviewer_comments
Aug 24, 2026
Merged

TOOLS-4263 Update the JS -> Go conversion skill based on reviewer comments#1148
autarch merged 1 commit into
masterfrom
08-20-tools-4263_update_the_js_-_go_conversion_skill_based_on_reviewer_comments

Conversation

@autarch

@autarch autarch commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

This was referenced Aug 20, 2026

autarch commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@autarch
autarch force-pushed the 08-20-tools-4263_update_the_js_-_go_conversion_skill_based_on_reviewer_comments branch from f1871f2 to 3d4e5ac Compare August 21, 2026 15:57
@autarch
autarch marked this pull request as ready for review August 21, 2026 16:29
@autarch
autarch requested a review from a team as a code owner August 21, 2026 16:29
@autarch
autarch requested review from fancywriter and a lite review from Copilot August 21, 2026 16:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the mongo-tools-js-to-go conversion Skill guidance to incorporate recurring reviewer feedback, with the goal of producing more reviewable, idiomatic Go integration tests when translating JS/resmoke tests in mongo-tools.

Changes:

  • Expands Go test code conventions (helper placement, bson guidance, loops, and set usage).
  • Adds new guidance sections on naming/scope, avoiding JS-provenance commentary in Go code, and maintaining fidelity to original JS test behavior.
  • Tightens the conversion process checklist to explicitly call out coverage gaps, unnecessary additions, and PR size management.
Suppressed comments (1)

.claude/skills/mongo-tools-js-to-go/SKILL.md:134

  • “the commit message, which is also the PR description” is not generally true on GitHub and could be misleading. If the intent is “put provenance in the commit message and the PR description”, it’s clearer to say so explicitly.
Provenance belongs in the **commit message**, which is also the PR description: name the JS
files the commit converts and deletes there.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .claude/skills/mongo-tools-js-to-go/SKILL.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants