TOOLS-4263 Update the JS -> Go conversion skill based on reviewer comments - #1148
Merged
autarch merged 1 commit intoAug 24, 2026
Conversation
This was referenced Aug 20, 2026
Collaborator
Author
autarch
force-pushed
the
08-20-tools-4263_update_the_js_-_go_conversion_skill_based_on_reviewer_comments
branch
from
August 21, 2026 15:57
f1871f2 to
3d4e5ac
Compare
autarch
marked this pull request as ready for review
August 21, 2026 16:29
There was a problem hiding this comment.
Pull request overview
Updates the mongo-tools-js-to-go conversion Skill guidance to incorporate recurring reviewer feedback, with the goal of producing more reviewable, idiomatic Go integration tests when translating JS/resmoke tests in mongo-tools.
Changes:
- Expands Go test code conventions (helper placement,
bsonguidance, loops, and set usage). - Adds new guidance sections on naming/scope, avoiding JS-provenance commentary in Go code, and maintaining fidelity to original JS test behavior.
- Tightens the conversion process checklist to explicitly call out coverage gaps, unnecessary additions, and PR size management.
Suppressed comments (1)
.claude/skills/mongo-tools-js-to-go/SKILL.md:134
- “the commit message, which is also the PR description” is not generally true on GitHub and could be misleading. If the intent is “put provenance in the commit message and the PR description”, it’s clearer to say so explicitly.
Provenance belongs in the **commit message**, which is also the PR description: name the JS
files the commit converts and deletes there.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fancywriter
approved these changes
Aug 24, 2026
autarch
force-pushed
the
08-20-tools-4263_update_the_js_-_go_conversion_skill_based_on_reviewer_comments
branch
from
August 24, 2026 15:58
3d4e5ac to
bd76a96
Compare
autarch
deleted the
08-20-tools-4263_update_the_js_-_go_conversion_skill_based_on_reviewer_comments
branch
August 24, 2026 17:12
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.