Skip to content

Use phpunit group instead of Atlas Data Lake test suite #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Use phpunit group instead of Atlas Data Lake test suite #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4718d12
Use phpunit group instead of Atlas Data Lake test suite
GromNaN Sep 6, 2023
de6c4f9
Merge branch 'master' into atlas-data-lake-test-suite
GromNaN Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .evergreen/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ case "$TESTS" in
;;

atlas-data-lake*)
php vendor/bin/simple-phpunit $PHPUNIT_OPTS --testsuite "Atlas Data Lake Test Suite"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to atlas* in the preceding case, I don't think we'll ever reach this case.

See: #1150 (comment)

php vendor/bin/simple-phpunit $PHPUNIT_OPTS --group atlas-data-lake
;;

csfle)
Expand Down
4 changes: 0 additions & 4 deletions phpunit.evergreen.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@
<testsuite name="Default Test Suite">
<directory>./tests/</directory>
</testsuite>

<testsuite name="Atlas Data Lake Test Suite">
<file>tests/SpecTests/AtlasDataLakeSpecTest.php</file>
</testsuite>
</testsuites>

<logging>
Expand Down
4 changes: 0 additions & 4 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,5 @@
<testsuite name="Default Test Suite">
<directory>./tests/</directory>
</testsuite>

<testsuite name="Atlas Data Lake Test Suite">
<file>tests/SpecTests/AtlasDataLakeSpecTest.php</file>
</testsuite>
</testsuites>
</phpunit>
1 change: 1 addition & 0 deletions tests/SpecTests/AtlasDataLakeSpecTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
* Atlas Data Lake spec tests.
*
* @see https://github.com/mongodb/specifications/tree/master/source/atlas-data-lake-testing/tests
* @group atlas-data-lake
*/
class AtlasDataLakeSpecTest extends FunctionalTestCase
{
Expand Down