Skip to content

PHPLIB-1168: Run atlas tests on an Atlas cluster #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Sep 6, 2023

PHPLIB-1168

This PR adds a new evergreen build configuration to run all tests in the atlas group on an Atlas cluster. At the moment, this is limited to search index spec tests, but may encompass more tests later.

To ensure the atlas cluster is shut down, this leverages a task group. No other tasks or build variants have changed, as that's handled in the separate CI cleanup.

I've included a run for the build variant in the patch build for this PR, but these tests will usually not be run as part of a pull request to save build resources.

@alcaeus alcaeus requested a review from GromNaN September 6, 2023 08:04
@alcaeus alcaeus self-assigned this Sep 6, 2023
@GromNaN GromNaN mentioned this pull request Sep 6, 2023
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alcaeus alcaeus merged commit b5462cf into mongodb:master Sep 6, 2023
@alcaeus alcaeus deleted the phplib-1168-evg-atlas-search-index-tests branch September 6, 2023 10:13
@@ -82,6 +82,10 @@ export MONGODB_MULTI_MONGOS_LB_URI="${MONGODB_MULTI_MONGOS_LB_URI}"

# Run the tests, and store the results in a junit result file
case "$TESTS" in
atlas*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't atlas* going to conflict with atlas-data-lake* below? Should we drop the asterisks? According to https://stackoverflow.com/a/4555979/162228, they do function as a wildcard for the pattern.

Just realized this while reviewing #1151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants