Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPC-2335: Replace hub with gh in Windows release workflow #1499

Merged
merged 1 commit into from
Dec 11, 2023
Merged

PHPC-2335: Replace hub with gh in Windows release workflow #1499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/windows-release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ jobs:
run: |
ARCHIVE=php_mongodb-${{ github.ref_name }}-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.arch }}.zip
zip $ARCHIVE php_mongodb.dll php_mongodb.pdb CREDITS CONTRIBUTING.md LICENSE README.md THIRD_PARTY_NOTICES
hub release edit -a $ARCHIVE -m "" $GITHUB_REF_NAME
gh release upload $GITHUB_REF_NAME $ARCHIVE
Copy link
Member Author

@jmikola jmikola Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hub is no longer available in runners, as evidenced by this CI failure. I'm going to manually attached the release assets to 1.17.1 in the meantime, but this should fix things going forward.

env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}