PHPC-2335: Replace hub with gh in Windows release workflow #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Dec 5, 2023
| @@ -32,6 +32,6 @@ jobs: | |||
| run: | | |||
| ARCHIVE=php_mongodb-${{ github.ref_name }}-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.arch }}.zip | |||
| zip $ARCHIVE php_mongodb.dll php_mongodb.pdb CREDITS CONTRIBUTING.md LICENSE README.md THIRD_PARTY_NOTICES | |||
| hub release edit -a $ARCHIVE -m "" $GITHUB_REF_NAME | |||
| gh release upload $GITHUB_REF_NAME $ARCHIVE | |||
There was a problem hiding this comment.
hub is no longer available in runners, as evidenced by this CI failure. I'm going to manually attached the release assets to 1.17.1 in the meantime, but this should fix things going forward.
GromNaN
approved these changes
Dec 11, 2023
|
This worked for the 1.17.2 release: https://github.com/mongodb/mongo-php-driver/actions/runs/7278892752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2335