Skip to content

Conversation

@katcharov
Copy link
Collaborator

Outstanding issues from JAVA-3879, primarily renames.

Largest renames were Expression->Mql, but this also includes (in separated commits) renames of methods that seemed inconsistent with similar methods, or which were otherwise problematic (for example, strLen became length, concat(fn) was renamed to concatArrays to distinguish it from array-array concat, and has was renamed to hasField for consistency with the other document accessors, and so on).

A dubious convenience method was removed, and missed null-checks and annotations were added (noticed in a prior PR, but too late to change there due to the scope of these renames).

Renames that were performed exclusively using automated tooling are in separate commits marked "automated".

@katcharov katcharov requested a review from stIncMale January 27, 2023 22:52
Base automatically changed from expressions-docs2 to expressions January 27, 2023 23:57
@katcharov katcharov force-pushed the expressions-renames branch from 024b85c to 1152643 Compare January 28, 2023 00:00
@katcharov
Copy link
Collaborator Author

Manually squashed some commits.

@katcharov katcharov force-pushed the expressions-renames branch from 581dad2 to 28c2833 Compare January 30, 2023 21:28
@katcharov katcharov merged this pull request into expressions Jan 30, 2023
@katcharov katcharov deleted the expressions-renames branch January 30, 2023 21:29
katcharov added a commit that referenced this pull request Jan 31, 2023
katcharov added a commit that referenced this pull request Jan 31, 2023
katcharov added a commit that referenced this pull request Jan 31, 2023
* Implement boolean expressions (#1025)

JAVA-4779

* Implement filter, map, reduce (#1031)

JAVA-4781

* Implement eq, ne, gt, gte, lt, lte (#1033)

JAVA-4784

* Implement string expressions (#1036)

JAVA-4801

* Implement arithmetic expressions (#1037)

Implement arithmetic expressions (from top 50, and others)

JAVA-4803

* Implement array expressions (#1043)

JAVA-4805

* Implement date expressions (#1045)

JAVA-4804

* Implement conversion/type expressions (#1050)

JAVA-4802

* Implement document expressions (#1052)

JAVA-4782

* Replace reduce with individual reductions (#1053)

JAVA-4814

* Implement map expressions (#1054)

JAVA-4817

* Implement switch expression (#1055)

JAVA-4813

* Test expressions in context (#1057)

JAVA-4820

* Add javadoc for boolean, date, number, integer, and expression (#1059)

 JAVA-4799

* Update and add documentation (#1059)

* Fix, tests

 JAVA-4799

* Add `@MqlUnchecked` and a few usage examples (#1059)

 JAVA-4799

* Add has to document, add tests (#1070)

 JAVA-4799

* Add javadocs for remaining classes (#1070)

 JAVA-4799

* 5.2 annotations (#1070)

 JAVA-4799

* 5.0 annotations (#1070)

 JAVA-4799

* 4.4 annotations (#1070)

 JAVA-4799

* 4.2 annotations (#1070)

 JAVA-4799

* 4.0 annotations (#1070)

 JAVA-4799

* Update and add documentation, add tests, fix minor issues (#1070)

Rename extractBsonValue

Fix access modifiers

Remove excess comments

Update docs

Fix: behaviour of get

Add notNull to API, add notNullApi test

Fix docs/annotations, tests

Fix docs, annotations, since

Fix docs

Revert external

Add missing MqlUnchecked

Fix missing null checks

Checkstyle

JAVA-4799

* Rename to Mql (automated) (#1073)

JAVA-3879

* Rename methods (automated) (#1073)

JAVA-3879

* Update naming, terms, and missing checks and annotations (#1073)

JAVA-3879

---------

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants