Javadoc for expressions, part 2 #1070

katcharov · 2023-01-20T22:44:42Z

The remaining docs for JAVA-4799, continuing #1059.

Also adds has to document, and a fix to multiply (found while writing docs).

stIncMale

Reviewed the first 2 commits but the DocumentExpression.

Some comments on array are also applicable to maps/documents and vice-versa, comments on BranchesIntermediary are also sometimes applicable to Branches.

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java

.../test/functional/com/mongodb/client/model/expressions/DocumentExpressionsFunctionalTest.java

driver-core/src/main/com/mongodb/client/model/expressions/BranchesIntermediary.java

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java

driver-core/src/main/com/mongodb/client/model/expressions/MapExpression.java

stIncMale

Reviewed DocumentExpression.

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java

driver-core/src/main/com/mongodb/client/model/expressions/MapExpression.java

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java

driver-core/src/main/com/mongodb/client/model/expressions/Expression.java

driver-core/src/main/com/mongodb/client/model/expressions/MapExpression.java

driver-core/src/main/com/mongodb/client/model/expressions/StringExpression.java

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java

driver-core/src/main/com/mongodb/annotations/Sealed.java

driver-core/src/main/com/mongodb/annotations/Evolving.java

driver-core/src/main/com/mongodb/client/model/expressions/EntryExpression.java

stIncMale · 2023-01-26T21:48:11Z

Currently, not all places that appear to need be documented with @MqlUnchecked are. Is more changes expected on this?

driver-core/src/main/com/mongodb/client/model/expressions/Expression.java

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java

Rename extractBsonValue Fix access modifiers Remove excess comments Update docs Fix: behaviour of get Add notNull to API, add notNullApi test Fix docs/annotations, tests Fix docs, annotations, since Fix docs Revert external Add missing MqlUnchecked Fix missing null checks Checkstyle

JAVA-4799

Rename extractBsonValue Fix access modifiers Remove excess comments Update docs Fix: behaviour of get Add notNull to API, add notNullApi test Fix docs/annotations, tests Fix docs, annotations, since Fix docs Revert external Add missing MqlUnchecked Fix missing null checks Checkstyle JAVA-4799

JAVA-4799

Rename extractBsonValue Fix access modifiers Remove excess comments Update docs Fix: behaviour of get Add notNull to API, add notNullApi test Fix docs/annotations, tests Fix docs, annotations, since Fix docs Revert external Add missing MqlUnchecked Fix missing null checks Checkstyle JAVA-4799

* Implement boolean expressions (#1025) JAVA-4779 * Implement filter, map, reduce (#1031) JAVA-4781 * Implement eq, ne, gt, gte, lt, lte (#1033) JAVA-4784 * Implement string expressions (#1036) JAVA-4801 * Implement arithmetic expressions (#1037) Implement arithmetic expressions (from top 50, and others) JAVA-4803 * Implement array expressions (#1043) JAVA-4805 * Implement date expressions (#1045) JAVA-4804 * Implement conversion/type expressions (#1050) JAVA-4802 * Implement document expressions (#1052) JAVA-4782 * Replace reduce with individual reductions (#1053) JAVA-4814 * Implement map expressions (#1054) JAVA-4817 * Implement switch expression (#1055) JAVA-4813 * Test expressions in context (#1057) JAVA-4820 * Add javadoc for boolean, date, number, integer, and expression (#1059) JAVA-4799 * Update and add documentation (#1059) * Fix, tests JAVA-4799 * Add `@MqlUnchecked` and a few usage examples (#1059) JAVA-4799 * Add has to document, add tests (#1070) JAVA-4799 * Add javadocs for remaining classes (#1070) JAVA-4799 * 5.2 annotations (#1070) JAVA-4799 * 5.0 annotations (#1070) JAVA-4799 * 4.4 annotations (#1070) JAVA-4799 * 4.2 annotations (#1070) JAVA-4799 * 4.0 annotations (#1070) JAVA-4799 * Update and add documentation, add tests, fix minor issues (#1070) Rename extractBsonValue Fix access modifiers Remove excess comments Update docs Fix: behaviour of get Add notNull to API, add notNullApi test Fix docs/annotations, tests Fix docs, annotations, since Fix docs Revert external Add missing MqlUnchecked Fix missing null checks Checkstyle JAVA-4799 * Rename to Mql (automated) (#1073) JAVA-3879 * Rename methods (automated) (#1073) JAVA-3879 * Update naming, terms, and missing checks and annotations (#1073) JAVA-3879 --------- Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>

katcharov requested review from jyemin, stIncMale and rozza and removed request for jyemin January 20, 2023 22:44

katcharov force-pushed the expressions-docs2 branch from ff468b7 to f8cb6a4 Compare January 23, 2023 23:38

katcharov mentioned this pull request Jan 23, 2023

Expressions #1032

Merged

stIncMale requested changes Jan 24, 2023

View reviewed changes

stIncMale reviewed Jan 24, 2023

View reviewed changes

driver-core/src/main/com/mongodb/client/model/expressions/Expression.java Show resolved Hide resolved

katcharov requested a review from stIncMale January 24, 2023 19:19

stIncMale reviewed Jan 25, 2023

View reviewed changes

driver-core/src/main/com/mongodb/client/model/expressions/MapExpression.java Show resolved Hide resolved

driver-core/src/main/com/mongodb/client/model/expressions/MapExpression.java Outdated Show resolved Hide resolved

stIncMale requested changes Jan 25, 2023

View reviewed changes

driver-core/src/main/com/mongodb/client/model/expressions/StringExpression.java Outdated Show resolved Hide resolved

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java Outdated Show resolved Hide resolved

katcharov requested a review from stIncMale January 26, 2023 19:22

stIncMale requested changes Jan 26, 2023

View reviewed changes

driver-core/src/main/com/mongodb/annotations/Sealed.java Show resolved Hide resolved

driver-core/src/main/com/mongodb/annotations/Evolving.java Outdated Show resolved Hide resolved

driver-core/src/main/com/mongodb/client/model/expressions/EntryExpression.java Show resolved Hide resolved

stIncMale requested changes Jan 27, 2023

View reviewed changes

driver-core/src/main/com/mongodb/client/model/expressions/Expression.java Show resolved Hide resolved

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java Show resolved Hide resolved

stIncMale approved these changes Jan 27, 2023

View reviewed changes

Base automatically changed from expressions-docs1 to expressions January 27, 2023 23:49

katcharov added 8 commits January 27, 2023 16:49

Add has to document, add tests

da21ccf

Add javadocs for remaining classes

e132dad

5.2 annotations

8f6de2c

5.0 annotations

026f500

4.4 annotations

03e3c01

4.2 annotations

e457cd4

4.0 annotations

b602571

katcharov force-pushed the expressions-docs2 branch from 7afdf1f to 3384440 Compare January 27, 2023 23:55

katcharov merged this pull request into expressions Jan 27, 2023

katcharov deleted the expressions-docs2 branch January 27, 2023 23:57

katcharov added a commit that referenced this pull request Jan 30, 2023

Add has to document, add tests (#1070)

c4c7e4b

JAVA-4799

katcharov added a commit that referenced this pull request Jan 30, 2023

Add javadocs for remaining classes (#1070)

14df144

JAVA-4799

katcharov added a commit that referenced this pull request Jan 30, 2023

5.2 annotations (#1070)

23ea666

JAVA-4799

katcharov added a commit that referenced this pull request Jan 30, 2023

5.0 annotations (#1070)

e37652d

JAVA-4799

katcharov added a commit that referenced this pull request Jan 30, 2023

4.4 annotations (#1070)

c76ca8b

JAVA-4799

katcharov added a commit that referenced this pull request Jan 30, 2023

4.2 annotations (#1070)

023a55d

JAVA-4799

katcharov added a commit that referenced this pull request Jan 30, 2023

4.0 annotations (#1070)

2a5f48f

JAVA-4799

katcharov added a commit that referenced this pull request Jan 31, 2023

Add has to document, add tests (#1070)

7ce9cb5

JAVA-4799

katcharov added a commit that referenced this pull request Jan 31, 2023

Add javadocs for remaining classes (#1070)

75cb0b7

JAVA-4799

katcharov added a commit that referenced this pull request Jan 31, 2023

5.2 annotations (#1070)

8de3396

JAVA-4799

katcharov added a commit that referenced this pull request Jan 31, 2023

5.0 annotations (#1070)

5680102

JAVA-4799

katcharov added a commit that referenced this pull request Jan 31, 2023

4.4 annotations (#1070)

b80bfcd

JAVA-4799

katcharov added a commit that referenced this pull request Jan 31, 2023

4.2 annotations (#1070)

6f24bea

JAVA-4799

katcharov added a commit that referenced this pull request Jan 31, 2023

4.0 annotations (#1070)

b1ae65d

JAVA-4799

Javadoc for expressions, part 2 #1070

Javadoc for expressions, part 2 #1070

Uh oh!

Conversation

katcharov commented Jan 20, 2023

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale commented Jan 26, 2023 •

edited

Loading