Convert change streams spec tests to unified format #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2022
prestonvasquez
approved these changes
May 20, 2022
qingyang-hu
approved these changes
May 20, 2022
benjirewis
commented
May 20, 2022
| @@ -454,7 +475,14 @@ func executeEstimatedDocumentCount(ctx context.Context, operation *operation) (* | |||
| } | |||
|
|
|||
| opts := options.EstimatedDocumentCount() | |||
| elems, _ := operation.Arguments.Elements() | |||
| var elems []bson.RawElement | |||
| // Some estimatedDocumentCount operations in the unified test format have no arguments. | |||
There was a problem hiding this comment.
Most of the estimatedDocumentCount operations in unified/estimatedDocumentCount do not have an arguments field, so I've added a special conditional here. I could add this to all execute* functions, but it should be easy to add later on if we encounter other operations with no arguments.
I checked to see who wrote these tests and decided to recklessly not include the arguments field, and it was me a year ago 😢 .
added 9 commits
May 20, 2022 14:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-1986
GODRIVER-2362
GODRIVER-2296
Converts the change streams spec tests to the unified test format. Removes the legacy change stream spec test runner and associated functions. Adds tests to ensure the "to" field is present in
renameevents. Adds tests to ensure we do not error when parsing change stream event documents. Bumps supported unified test format schema version to 1.7. Adds support forignoreExtraEventsand therenameoperation in the unified test runner.