GODRIVER-2340 Allow the setting of timeoutMS on operations in the UTR. #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
May 20, 2022
benjirewis
commented
May 20, 2022
kevinAlbs
reviewed
May 23, 2022
benjirewis
force-pushed
the
csot-implementation
branch
from
4082b3d to
8529ddd
Compare
benjirewis
changed the title
benjirewis
force-pushed
the
csot-implementation
branch
from
8529ddd to
97b6068
Compare
benjirewis
added a commit
that referenced
this pull request
Jun 2, 2022
benjirewis
added a commit
that referenced
this pull request
Jun 3, 2022
benjirewis
added a commit
that referenced
this pull request
Jun 6, 2022
GODRIVER-2341 Add Timeout to Client, Database, Collection and all basic operations. (#925) GODRIVER-2340 GODRIVER-2405 Test RTT90 monitoring. (#948) GODRIVER-2340 Allow the setting of timeoutMS on operations in the UTR. (#955)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2340
Syncs the
override-operation-timeouttests that ensure thattimeoutMSis set and respected at the operation level (first commit). The Go driver will not actually support settingTimeoutthrough*Optionson individual operations; instead, we'll expect users to include a timeout on the passed-inContext, as that is more idiomatic. Modifies therunfunction to create aContextwithtimeoutMSas the timeout iftimeoutMSis specified in the operation arguments. Modifiesexecute*functions to set aTimeoutof 0 on the caller of the operation in order to opt-in to behavior gated behind the presence of theTimeoutvariable.Opening PRs with
csot-implementationas the base branch messes with the GH Evergreen CI: so here is a patch I'll keep updated with every commit.