Skip to content

Fix JSON strcmp against BSON array following mongo-c-driver f2c1bb79 #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Fix JSON strcmp against BSON array following mongo-c-driver f2c1bb79 #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf4eb6f
Fix JSON strcmp against BSON array following mongo-c-driver f2c1bb79
eramongodb Jan 22, 2025
35e1b77
Set downloaded mongoc version to f2c1bb79
eramongodb Jan 22, 2025
5db3be8
Add reference to CXX-3208
eramongodb Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .evergreen/config_generator/components/funcs/install_c_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# Only LIBMONGOC_DOWNLOAD_VERSION needs to be updated when pinning to an unreleased commit.
# If pinning to an unreleased commit, create a "Blocked" JIRA ticket with
# a "depends on" link to the appropriate C Driver version release ticket.
MONGOC_VERSION_MINIMUM = '1.29.0'
MONGOC_VERSION_MINIMUM = 'f2c1bb7989177fa2ddba1a915e8423e46ee1defe' # CXX-3208: bump to 1.30.0 once released.


class InstallCDriver(Function):
Expand Down
2 changes: 1 addition & 1 deletion .evergreen/generated_configs/functions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ functions:
type: setup
params:
updates:
- { key: mongoc_version_minimum, value: 1.29.0 }
- { key: mongoc_version_minimum, value: f2c1bb7989177fa2ddba1a915e8423e46ee1defe }
- command: subprocess.exec
type: setup
params:
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ set(LIBBSON_REQUIRED_ABI_VERSION 1.0)

# Also update etc/purls.txt.
set(LIBMONGOC_REQUIRED_VERSION 1.29.0)
set(LIBMONGOC_DOWNLOAD_VERSION 1.29.0)
set(LIBMONGOC_DOWNLOAD_VERSION f2c1bb7989177fa2ddba1a915e8423e46ee1defe)
set(LIBMONGOC_REQUIRED_ABI_VERSION 1.0)

set(NEED_DOWNLOAD_C_DRIVER false)
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/test/json.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ TEST_CASE("empty array is converted correctly to json string") {
using bsoncxx::to_json;

auto doc = make_document(kvp("array", make_array()));
REQUIRE(to_json(doc.view()) == R"({ "array" : [ ] })");
REQUIRE(to_json(doc.view()) == R"({ "array" : [ ] })");
}

TEST_CASE("CXX-941 is resolved") {
Expand Down