Fix JSON strcmp against BSON array following mongo-c-driver f2c1bb79 #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looks good to me, thanks. There were at least two other very minor changes to JSON output: the new serializer added recursion bounds to codewscope which was previously missing them, and instead of using "{ ... }" to indicate both omitted arrays and documents it now has "[ ... ]" to signify an array omitted due to hitting the recursion limit.
kevinAlbs
approved these changes
Jan 22, 2025
ghost
mentioned this pull request
ghost
pushed a commit
to mongodb/mongo-c-driver
that referenced
this pull request
Jan 23, 2025
This is a follow-up to #1816 and mongodb/mongo-cxx-driver#1322, documenting minor changes to JSON output subsequent to change f2c1bb7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to mongodb/mongo-c-driver#1816.
This appears to be the only breaking change introduced by mongodb/mongo-c-driver@f2c1bb7 as observed by the C++ Driver test suite, verified by this patch.
It may be worthwhile to remember to include a note in the upcoming C Driver release notes that the whitespace formatting of JSON output may have slightly changed. Then again, I do not expect users to be equality-comparing the contents of JSON strings, let alone JSON strings of empty arrays, so this could be considered an unnecessary gesture.